Skip to content

Search calendar by DateTime.Today, not UtcNow#589

Merged
JW-CH merged 1 commit intomainfrom
dev.3rob3.CalendarDateFix
Feb 11, 2026
Merged

Search calendar by DateTime.Today, not UtcNow#589
JW-CH merged 1 commit intomainfrom
dev.3rob3.CalendarDateFix

Conversation

@3rob3
Copy link
Collaborator

@3rob3 3rob3 commented Feb 7, 2026 •
edited by coderabbitai bot
Loading

Closes #401

Summary by CodeRabbit

  • Bug Fixes
    • Fixed calendar appointment retrieval to use local date rather than UTC time, ensuring correct appointments are displayed.

@3rob3 3rob3 added the bug Something isn't working label Feb 7, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The GetAppointments method in the IcalCalendarService now retrieves calendar occurrences using local DateTime.Today as the start boundary instead of UTC-based DateTime.UtcNow, refining the time interval for appointment fetching.

Changes

Cohort / File(s) Summary
Calendar Appointment Retrieval
ImmichFrame.Core/Services/IcalCalendarService.cs		 Modified appointment query window start time from DateTime.UtcNow to DateTime.Today, changing from UTC-based current moment to local date boundary.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

fix

Poem

🐰 A rabbit hops through calendar days,
With local time to light the ways,
No more UTC's confusing dance,
Just today's date—a clearer stance!
The appointments now align just right, 📅✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: switching calendar search from DateTime.UtcNow to DateTime.Today, which aligns with the code modification.
Linked Issues check ✅ Passed The PR addresses the calendar integration issue by fixing the date/time logic used for retrieving calendar occurrences, which could resolve the missing calendar display problem reported in issue #401.
Out of Scope Changes check ✅ Passed The single-line change is directly scoped to the calendar search functionality issue identified in #401, with no unrelated modifications present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev.3rob3.CalendarDateFix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@3rob3 3rob3 self-assigned this Feb 7, 2026
@JW-CH JW-CH merged commit 828fe96 into main Feb 11, 2026
8 of 9 checks passed
@JW-CH JW-CH deleted the dev.3rob3.CalendarDateFix branch February 11, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@3rob3 3rob3

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Iframe - Google Calendar integration

2 participants

@3rob3 @JW-CH